Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form:select): fix ignore reset option data when set onSearch #1644

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Sep 1, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Sep 1, 2023

Preview is ready!

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #1644 (2829afc) into master (79e229f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2829afc differs from pull request most recent head 8fd4da1. Consider uploading reports for the commit 8fd4da1 to get more accurate results

@@           Coverage Diff           @@
##           master    #1644   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files         281      281           
  Lines        8740     8741    +1     
  Branches     1731     1732    +1     
=======================================
+ Hits         8353     8354    +1     
  Misses        319      319           
  Partials       68       68           
Files Changed Coverage Δ
packages/form/src/widgets/select/select.widget.ts 96.29% <100.00%> (+0.06%) ⬆️

@cipchk cipchk merged commit 1f8def7 into master Sep 1, 2023
8 checks passed
@cipchk cipchk deleted the issues-2415 branch September 1, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select表单重置后无选项
2 participants