Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(abc:onboarding): add key #1652

Merged
merged 3 commits into from
Oct 17, 2023
Merged

feat(abc:onboarding): add key #1652

merged 3 commits into from
Oct 17, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Sep 14, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Sep 14, 2023

Preview is ready!

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #1652 (5402797) into master (60699d5) will decrease coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is 80.95%.

❗ Current head 5402797 differs from pull request most recent head 966d98a. Consider uploading reports for the commit 966d98a to get more accurate results

@@            Coverage Diff             @@
##           master    #1652      +/-   ##
==========================================
- Coverage   95.57%   95.53%   -0.04%     
==========================================
  Files         281      282       +1     
  Lines        8741     8756      +15     
  Branches     1732     1734       +2     
==========================================
+ Hits         8354     8365      +11     
- Misses        319      323       +4     
  Partials       68       68              
Files Changed Coverage Δ
packages/abc/onboarding/onboarding.storage.ts 42.85% <42.85%> (ø)
packages/abc/onboarding/onboarding.service.ts 98.00% <100.00%> (+0.17%) ⬆️

@cipchk cipchk merged commit 5edaa97 into master Oct 17, 2023
9 checks passed
@cipchk cipchk deleted the issues-obs-key branch October 17, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants