Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): fix visibleIf to correctly trigger reset #1653

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Sep 19, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Sep 19, 2023

Preview is ready!

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #1653 (52be3f4) into master (76db16c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 52be3f4 differs from pull request most recent head 11d338e. Consider uploading reports for the commit 11d338e to get more accurate results

@@           Coverage Diff           @@
##           master    #1653   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files         281      281           
  Lines        8738     8742    +4     
  Branches     1732     1732           
=======================================
+ Hits         8351     8355    +4     
  Misses        319      319           
  Partials       68       68           
Files Changed Coverage Δ
packages/form/src/model/array.property.ts 100.00% <100.00%> (ø)
packages/form/src/model/form.property.factory.ts 100.00% <100.00%> (ø)
packages/form/src/model/form.property.ts 98.03% <100.00%> (+0.02%) ⬆️
packages/form/src/model/object.property.ts 100.00% <100.00%> (ø)
packages/form/src/sf.component.ts 96.58% <100.00%> (ø)

@cipchk cipchk merged commit d80f8fb into master Oct 17, 2023
8 checks passed
@cipchk cipchk deleted the issues-2419 branch October 17, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(form): fix visibleIf to correctly trigger reset
2 participants