Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form:array): fix invalid ui in ui schema #1657

Merged
merged 2 commits into from
Oct 17, 2023
Merged

fix(form:array): fix invalid ui in ui schema #1657

merged 2 commits into from
Oct 17, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Oct 17, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Oct 17, 2023

Preview is ready!

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1657 (8d13ebf) into master (d80f8fb) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 8d13ebf differs from pull request most recent head 3dfddaa. Consider uploading reports for the commit 3dfddaa to get more accurate results

@@            Coverage Diff             @@
##           master    #1657      +/-   ##
==========================================
- Coverage   95.57%   95.57%   -0.01%     
==========================================
  Files         281      281              
  Lines        8742     8741       -1     
  Branches     1646     1646              
==========================================
- Hits         8355     8354       -1     
  Misses        319      319              
  Partials       68       68              
Files Coverage Δ
packages/form/src/sf.component.ts 96.57% <100.00%> (-0.02%) ⬇️

@cipchk cipchk merged commit 6b3c711 into master Oct 17, 2023
9 checks passed
@cipchk cipchk deleted the issues-2429 branch October 17, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sf的array元素通过sf的ui设置grid无效
2 participants