Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(abc:qr): will be removed in 18.0.0 #1667

Merged
merged 3 commits into from
Oct 26, 2023
Merged

feat(abc:qr): will be removed in 18.0.0 #1667

merged 3 commits into from
Oct 26, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Oct 21, 2023

Please use nz-qrcode instead.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Oct 21, 2023

Preview is ready!

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #1667 (906cfff) into master (de138d5) will increase coverage by 0.01%.
Report is 3 commits behind head on master.
The diff coverage is 87.50%.

❗ Current head 906cfff differs from pull request most recent head a0a8494. Consider uploading reports for the commit a0a8494 to get more accurate results

@@            Coverage Diff             @@
##           master    #1667      +/-   ##
==========================================
+ Coverage   96.16%   96.17%   +0.01%     
==========================================
  Files         282      282              
  Lines        8758     8758              
  Branches     1649     1649              
==========================================
+ Hits         8422     8423       +1     
+ Misses        324      323       -1     
  Partials       12       12              
Files Coverage Δ
packages/abc/qr/qr.component.ts 98.00% <ø> (ø)
packages/abc/qr/qr.module.ts 100.00% <ø> (ø)
packages/theme/src/services/modal/modal.helper.ts 89.28% <87.50%> (ø)

... and 1 file with indirect coverage changes

@cipchk cipchk merged commit 5a7bdd4 into master Oct 26, 2023
10 checks passed
@cipchk cipchk deleted the issues-deprecated-qr branch October 26, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants