Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(abc:cell): add provideCellWidgets #1700

Merged
merged 3 commits into from
Nov 12, 2023
Merged

feat(abc:cell): add provideCellWidgets #1700

merged 3 commits into from
Nov 12, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Nov 12, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Nov 12, 2023

Preview is ready!

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #1700 (e81b48b) into master (501566b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e81b48b differs from pull request most recent head f68c916. Consider uploading reports for the commit f68c916 to get more accurate results

@@           Coverage Diff           @@
##           master    #1700   +/-   ##
=======================================
  Coverage   95.45%   95.45%           
=======================================
  Files         300      301    +1     
  Lines        8823     8828    +5     
  Branches     1659     1659           
=======================================
+ Hits         8422     8427    +5     
  Misses        331      331           
  Partials       70       70           
Files Coverage Δ
packages/abc/cell/cell-host.directive.ts 100.00% <ø> (ø)
packages/abc/cell/cell.component.ts 98.36% <100.00%> (ø)
packages/abc/cell/cell.module.ts 100.00% <ø> (ø)
packages/abc/cell/provide.ts 100.00% <100.00%> (ø)

@cipchk cipchk merged commit 7ea0daf into master Nov 12, 2023
9 checks passed
@cipchk cipchk deleted the cell-provide branch November 12, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants