Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form): add setDisabled, setRequired method #1733

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Dec 14, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Dec 14, 2023

Preview is ready!

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5eafa8f) 94.94% compared to head (b50e232) 94.93%.
Report is 1 commits behind head on master.

Files Patch % Lines
packages/form/src/sf.component.ts 90.90% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1733      +/-   ##
==========================================
- Coverage   94.94%   94.93%   -0.01%     
==========================================
  Files         316      316              
  Lines        8904     8926      +22     
  Branches     1679     1772      +93     
==========================================
+ Hits         8454     8474      +20     
  Misses        379      379              
- Partials       71       73       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cipchk cipchk merged commit 581f197 into master Jan 11, 2024
9 of 11 checks passed
@cipchk
Copy link
Member Author

cipchk commented Jan 11, 2024

Preview is ready!

@cipchk cipchk deleted the issues-form-disabled-required branch July 1, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants