Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(*): use inject instead constructor #1755

Merged
merged 22 commits into from
Jan 20, 2024
Merged

refactor(*): use inject instead constructor #1755

merged 22 commits into from
Jan 20, 2024

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jan 18, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@cipchk
Copy link
Member Author

cipchk commented Jan 18, 2024

Preview is ready!

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (4e7f334) 93.84% compared to head (f09927b) 93.70%.

Files Patch % Lines
packages/abc/st/st-export.ts 42.85% 4 Missing ⚠️
packages/abc/pdf/pdf.component.ts 83.33% 3 Missing ⚠️
packages/abc/reuse-tab/reuse-tab.component.ts 86.95% 1 Missing and 2 partials ⚠️
...kages/theme/layout-default/layout-top-menu-item.ts 0.00% 2 Missing ⚠️
packages/abc/st/st.component.ts 96.87% 1 Missing ⚠️
packages/abc/sv/sv-container.component.ts 90.00% 1 Missing ⚠️
packages/abc/sv/sv.component.ts 94.44% 1 Missing ⚠️
packages/abc/tag-select/tag-select.component.ts 88.88% 1 Missing ⚠️
packages/cache/src/cache.service.ts 80.00% 1 Missing ⚠️
packages/util/format/currency.service.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1755      +/-   ##
==========================================
- Coverage   93.84%   93.70%   -0.15%     
==========================================
  Files         316      316              
  Lines        8786     8781       -5     
  Branches     1620     1644      +24     
==========================================
- Hits         8245     8228      -17     
- Misses        483      491       +8     
- Partials       58       62       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cipchk cipchk merged commit 0e238e7 into master Jan 20, 2024
8 of 9 checks passed
@cipchk cipchk changed the title perf(*): use inject instead constructor refactor(*): use inject instead constructor Jan 20, 2024
@cipchk cipchk deleted the perf-inject branch July 1, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant