Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(abc:cell): widget data type changed to CellTextResult #1771

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Mar 11, 2024

Breaking Changes:
为了保持数据处理结果的统一性,将小部件的 data 类型由原来的 CellWidgetData 变更为 CellTextResult 以此来保证数据为处理后的结果。

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

Breaking Changes:
为了保持数据处理结果的统一性,将小部件的 `data` 类型由原来的 `CellWidgetData` 变更为 `CellTextResult` 以此来保证数据为处理后的结果。
@cipchk
Copy link
Member Author

cipchk commented Mar 11, 2024

Preview is ready!

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.72%. Comparing base (b7ea5ac) to head (e08259c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1771      +/-   ##
==========================================
- Coverage   93.72%   93.72%   -0.01%     
==========================================
  Files         317      317              
  Lines        8808     8806       -2     
  Branches     1653     1653              
==========================================
- Hits         8255     8253       -2     
  Misses        491      491              
  Partials       62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cipchk cipchk merged commit 20cf83a into master Mar 11, 2024
9 checks passed
@cipchk cipchk changed the title refactor(abc:cell): widget data type changed to CellTextResult refactor(abc:cell): widget data type changed to CellTextResult Mar 11, 2024
@cipchk cipchk deleted the issues-cell branch July 1, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant