Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abc:notice-icon): fix incorrect unsubscription #1794

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Apr 12, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@cipchk
Copy link
Member Author

cipchk commented Apr 12, 2024

Preview Build Failed!

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.86%. Comparing base (1ff2ddb) to head (d71e1d1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1794      +/-   ##
==========================================
+ Coverage   93.73%   94.86%   +1.13%     
==========================================
  Files         317      317              
  Lines        8812     8965     +153     
  Branches     1652     1805     +153     
==========================================
+ Hits         8260     8505     +245     
+ Misses        490      383     -107     
- Partials       62       77      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cipchk cipchk merged commit 4077073 into master Apr 12, 2024
8 of 9 checks passed
@cipchk cipchk deleted the issues-notice-icon-sub branch July 1, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant