refactor: Improve URL query parameter handling for correct concatenat… #1821
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current URL handling does not correctly concatenate query parameters if the URL already contains existing parameters.
exp:
lodop.service.ts#request:
https://print.xxx.com:8443/CLodopfuncs.js?AOListCount=100?name=CLodop
What is the new behavior?
The URL handling has been refactored to correctly concatenate query parameters even if the URL already contains existing parameters. The new implementation also ensures proper encoding of the query parameters.
exp:
https://print.xxx.com:8443/CLodopfuncs.js?AOListCount=100&name=CLodop
Does this PR introduce a breaking change?
Other information