Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theme:modal): support build-in and focus button #1828

Merged
merged 3 commits into from
Sep 17, 2024

chore: fix time value

e74dd0f
Select commit
Loading
Failed to load commit list.
Merged

feat(theme:modal): support build-in and focus button #1828

chore: fix time value
e74dd0f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 26, 2024 in 1s

94.87% (-0.03%) compared to da2fea1

View this Pull Request on Codecov

94.87% (-0.03%) compared to da2fea1

Details

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.87%. Comparing base (da2fea1) to head (e74dd0f).
Report is 4 commits behind head on master.

Files Patch % Lines
packages/theme/src/services/modal/modal.helper.ts 86.36% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1828      +/-   ##
==========================================
- Coverage   94.89%   94.87%   -0.03%     
==========================================
  Files         315      315              
  Lines        8911     8929      +18     
  Branches     1688     1698      +10     
==========================================
+ Hits         8456     8471      +15     
- Misses        381      382       +1     
- Partials       74       76       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov