Add configurable delayed termination instructions #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
kate-osborn
requested changes
Oct 20, 2023
ciarams87
force-pushed
the
docs/zero-downtime
branch
from
1d5075d to
9f4310f
Compare
ciarams87
changed the title
sjberman
reviewed
Oct 23, 2023
bjee19
requested changes
Oct 23, 2023
ciarams87
force-pushed
the
docs/zero-downtime
branch
from
7b901a8 to
96061cc
Compare
ciarams87
force-pushed
the
docs/zero-downtime
branch
from
96061cc to
db6201f
Compare
sjberman
approved these changes
Oct 23, 2023
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
* Add configurable delayed termination instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
As a cluster admin
I would like to be able to upgrade NGF with zero downtime for my clients
So that there is no interruption in client traffic while the upgrade is occurring
Solution:
Please focus on (optional): This is dependant on #1155 being merged first
I also added TOCs to the updated files.
Closes #1154
Checklist
Before creating a PR, run through this checklist and mark each as complete.