-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ephemeral debugging guide #1202
Conversation
962191a
to
0a03010
Compare
Closing until I figure out why it's not working for everyone |
Does anyone on the team use VSCode? If so, and you get this working, would love to see what your |
Nevermind, user error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Would you like me to migrate this to the website once merged?
@ADubhlaoich no thanks! This is a developer doc and doesn't need to be on the public site. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works well!
I left a few questions.
9efa473
to
515a1ec
Compare
Problem: No documentation on how to debug NGF in Kubernetes Solution: Add a developer guide with step-by-step instructions on how to inject an ephemeral dlv debug container into NGF while it's running in a cluster. Includes makefile targets to make the process easier and a dockerfile for the dlv debug image.
Proposed changes
Problem: No documentation on how to debug NGF in Kubernetes
Solution: Add a developer guide with step-by-step instructions on how to inject an ephemeral dlv debug container into NGF while it's running in a cluster. Includes makefile targets to make the process easier and a dockerfile for the dlv debug image.
Testing: Ran through the steps in the guide to make sure it works.
Closes #1201
Checklist
Before creating a PR, run through this checklist and mark each as complete.