Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SnippetFilter CRD #2472

Merged

Conversation

salonichf5
Copy link
Contributor

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: User wants to define a CRD for snippetsFilter to apply custom nginx configurations

Solution: Defined a CRD for snippetsFilter

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #2415

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@salonichf5 salonichf5 requested review from a team as code owners August 27, 2024 22:27
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 27, 2024
@salonichf5 salonichf5 changed the title add api spec for snippets filter Add SnippetFilter CRD Aug 27, 2024
@salonichf5 salonichf5 marked this pull request as draft August 27, 2024 22:27
@salonichf5 salonichf5 force-pushed the feat/snippetsFilter branch from 8f5453b to 3ab1863 Compare August 27, 2024 22:31
@sjberman
Copy link
Collaborator

Let's create a feature branch and target this PR for that, since we're still trying to figure out the solution here.

apis/v1alpha1/snippetsfilter_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/snippetsfilter_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/snippetsfilter_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/snippetsfilter_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/snippetsfilter_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/snippetsfilter_types.go Outdated Show resolved Hide resolved
@salonichf5 salonichf5 marked this pull request as ready for review August 29, 2024 16:02
@salonichf5
Copy link
Contributor Author

Let's create a feature branch and target this PR for that, since we're still trying to figure out the solution here.

I have created this branch

@salonichf5 salonichf5 force-pushed the feat/snippetsFilter branch from 3ab1863 to 08bdb2b Compare August 29, 2024 16:39
@salonichf5 salonichf5 changed the base branch from main to feature/snippets-filter August 29, 2024 16:39
@salonichf5 salonichf5 force-pushed the feat/snippetsFilter branch from 08bdb2b to b66ba1e Compare August 30, 2024 13:56
@github-actions github-actions bot added the tests Pull requests that update tests label Aug 30, 2024
@salonichf5 salonichf5 force-pushed the feat/snippetsFilter branch from b66ba1e to 7bade8c Compare August 30, 2024 14:03
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (77114a2) to head (dccff20).
Report is 1 commits behind head on feature/snippets-filter.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature/snippets-filter    #2472   +/-   ##
========================================================
  Coverage                    89.21%   89.21%           
========================================================
  Files                          100      100           
  Lines                         7539     7539           
  Branches                        50       50           
========================================================
  Hits                          6726     6726           
  Misses                         756      756           
  Partials                        57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@salonichf5 salonichf5 force-pushed the feat/snippetsFilter branch from 7bade8c to 1f074c0 Compare August 30, 2024 19:08
@github-actions github-actions bot removed the tests Pull requests that update tests label Aug 30, 2024
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like feature branch needs to be rebased again

apis/v1alpha1/snippetsfilter_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/snippetsfilter_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/snippetsfilter_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/snippetsfilter_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/snippetsfilter_types.go Outdated Show resolved Hide resolved
@sjberman
Copy link
Collaborator

sjberman commented Sep 3, 2024

This also needs to be added to the list in register.go.

apis/v1alpha1/snippetsfilter_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/snippetsfilter_types.go Outdated Show resolved Hide resolved
@salonichf5 salonichf5 merged commit 3882612 into nginx:feature/snippets-filter Sep 3, 2024
20 checks passed
kate-osborn pushed a commit that referenced this pull request Sep 4, 2024
Problem: User wants to define a CRD for snippetsFilter to apply custom nginx configurations

Solution: Defined a CRD for snippetsFilter
kate-osborn pushed a commit that referenced this pull request Sep 24, 2024
Problem: User wants to define a CRD for snippetsFilter to apply custom nginx configurations

Solution: Defined a CRD for snippetsFilter
salonichf5 added a commit that referenced this pull request Oct 8, 2024
Problem: User wants to define a CRD for snippetsFilter to apply custom nginx configurations

Solution: Defined a CRD for snippetsFilter
salonichf5 added a commit that referenced this pull request Oct 8, 2024
Problem: User wants to define a CRD for snippetsFilter to apply custom nginx configurations

Solution: Defined a CRD for snippetsFilter
sjberman pushed a commit that referenced this pull request Oct 8, 2024
Problem: User wants to define a CRD for snippetsFilter to apply custom nginx configurations

Solution: Defined a CRD for snippetsFilter
salonichf5 added a commit that referenced this pull request Oct 8, 2024
Problem: User wants to define a CRD for snippetsFilter to apply custom nginx configurations

Solution: Defined a CRD for snippetsFilter
salonichf5 added a commit that referenced this pull request Oct 8, 2024
Problem: User wants to define a CRD for snippetsFilter to apply custom nginx configurations

Solution: Defined a CRD for snippetsFilter
sjberman pushed a commit that referenced this pull request Oct 9, 2024
Problem: User wants to define a CRD for snippetsFilter to apply custom nginx configurations

Solution: Defined a CRD for snippetsFilter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defined SnippetsFilter CRD
3 participants