-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SnippetFilter CRD #2472
Add SnippetFilter CRD #2472
Conversation
8f5453b
to
3ab1863
Compare
Let's create a feature branch and target this PR for that, since we're still trying to figure out the solution here. |
I have created this branch |
3ab1863
to
08bdb2b
Compare
08bdb2b
to
b66ba1e
Compare
b66ba1e
to
7bade8c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/snippets-filter #2472 +/- ##
========================================================
Coverage 89.21% 89.21%
========================================================
Files 100 100
Lines 7539 7539
Branches 50 50
========================================================
Hits 6726 6726
Misses 756 756
Partials 57 57 ☔ View full report in Codecov by Sentry. |
7bade8c
to
1f074c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like feature branch needs to be rebased again
This also needs to be added to the list in |
1f074c0
to
1ca96ef
Compare
Co-authored-by: Kate Osborn <[email protected]>
Co-authored-by: Kate Osborn <[email protected]>
Co-authored-by: Kate Osborn <[email protected]>
Co-authored-by: Kate Osborn <[email protected]>
d00e2fa
to
8d2ccf9
Compare
af61cd0
to
dccff20
Compare
Problem: User wants to define a CRD for snippetsFilter to apply custom nginx configurations Solution: Defined a CRD for snippetsFilter
Problem: User wants to define a CRD for snippetsFilter to apply custom nginx configurations Solution: Defined a CRD for snippetsFilter
Problem: User wants to define a CRD for snippetsFilter to apply custom nginx configurations Solution: Defined a CRD for snippetsFilter
Problem: User wants to define a CRD for snippetsFilter to apply custom nginx configurations Solution: Defined a CRD for snippetsFilter
Problem: User wants to define a CRD for snippetsFilter to apply custom nginx configurations Solution: Defined a CRD for snippetsFilter
Problem: User wants to define a CRD for snippetsFilter to apply custom nginx configurations Solution: Defined a CRD for snippetsFilter
Problem: User wants to define a CRD for snippetsFilter to apply custom nginx configurations Solution: Defined a CRD for snippetsFilter
Problem: User wants to define a CRD for snippetsFilter to apply custom nginx configurations Solution: Defined a CRD for snippetsFilter
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: User wants to define a CRD for snippetsFilter to apply custom nginx configurations
Solution: Defined a CRD for snippetsFilter
Testing: Describe any testing that you did.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #2415
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.