-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otel: Update some rust crates #1504
Conversation
Rebased with master
|
Fix subject typo
|
I'd suggest a more generic commit message, a la:
|
I'd advise a full run of |
Rebase with master...
|
Update all crates required by OTEL.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subjected updated code to performance tests and got expected results.
Run 'cargo update' to get the latest version of the required crates in preparation for the 1.34.0 release. The rustls update fixes a panic in `rustls::server::Acceptor::accept()`, but Unit does not use this code path and was not affected. Link: <https://rustsec.org/advisories/RUSTSEC-2024-0399.html> Link: <https://github.com/nginx/unit/security/dependabot/11> Closes: <nginx#1503> Signed-off-by: Andrew Clayton <[email protected]>
Rebased with master
|
Acceptor::accept
'That also requires an update to rustls-pki-types
It's not clear that this is actually a problem for us and we have two different versions in Cargo.lock, one which isn't vulnerable, but just bump the other version anyway, if you try and remove it altogether it gets added back...
Link: https://rustsec.org/advisories/RUSTSEC-2024-0399.html
Link: https://github.com/nginx/unit/security/dependabot/11