Docker: Mount rust from image at build time instead of downloading it #1522
Conversation
pkg/docker/Dockerfile.go1.22
Outdated
| @@ -8,30 +10,16 @@ LABEL org.opencontainers.image.documentation="https://unit.nginx.org/installatio | |||
| LABEL org.opencontainers.image.vendor="NGINX Docker Maintainers <[email protected]>" | |||
| LABEL org.opencontainers.image.version="1.34.0" | |||
|
|
|||
| RUN set -ex \ | |||
| RUN --mount=type=bind,target=/rust,from=rust,rw \ | |||
There was a problem hiding this comment.
Because this is from= a stage, it would be mostly OK, but it's technically not officially supported in the DOI build system / dependency calculation, so adding it makes me a little nervous: https://github.com/docker-library/bashbrew/blob/f71d6ef63e1f5abe6d5cb06a62a3e5e42d68566e/cmd/bashbrew/docker.go#L96-L190
(For example, if we accept this, and then the FROM ... AS rust gets removed later, we won't necessarily remember the implications of that meaning that this line now implies from=rust:latest which will "just work" but not be accounted for correctly in our dependency calculations.)
There was a problem hiding this comment.
Would using a target that isn't matching an image solve this such as rust-build?
pkg/docker/Dockerfile.go1.22
Outdated
| @@ -1,3 +1,5 @@ | |||
| FROM rust:1.83.0-bookworm AS rust | |||
There was a problem hiding this comment.
The rust image only maintains a single version at any given time, so this is only reasonable if it's going to be proactively kept up-to-date. 😬
LaurentGoderre
force-pushed
the
optimize-docker
branch
5 times, most recently
from
2c9ba88 to
8e1f00d
Compare
This ensures that rust is not left behind in the image
LaurentGoderre
force-pushed
the
optimize-docker
branch
from
8e1f00d to
bbefca2
Compare
This ensures that rust is not left behind in the image