-
-
Notifications
You must be signed in to change notification settings - Fork 41
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
In this commit, we enable strict mode because it is required to generate correct type definition (`.d.ts`) files. These files differ depending on whether strict mode is enabled or disabled. Enabling strict mode allows `null|undefined` values to be provided by the parent component (e.g., `[tp]="null"`, which should be allowed), but the compiler removes `null|undefined` values from the binding. We also had to patch the `@popperjs/core` types due to a mistake in their definitions. This patch was necessary for successful compilation
- Loading branch information
Showing
12 changed files
with
417 additions
and
98 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff --git a/node_modules/tippy.js/node_modules/@popperjs/core/lib/types.d.ts b/node_modules/tippy.js/node_modules/@popperjs/core/lib/types.d.ts | ||
index 11f9219..f971927 100644 | ||
--- a/node_modules/tippy.js/node_modules/@popperjs/core/lib/types.d.ts | ||
+++ b/node_modules/tippy.js/node_modules/@popperjs/core/lib/types.d.ts | ||
@@ -114,7 +114,7 @@ export declare type ModifierArguments<Options extends Obj> = { | ||
options: Partial<Options>; | ||
name: string; | ||
}; | ||
-export declare type Modifier<Name, Options> = { | ||
+export declare type Modifier<Name, Options extends object> = { | ||
name: Name; | ||
enabled: boolean; | ||
phase: ModifierPhases; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.