Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update guide with traffic policy #737

Merged
merged 4 commits into from
May 17, 2024
Merged

Conversation

OfTheDelmer
Copy link
Contributor

Updates the guide with initial section for the traffic policy docs

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ngrok-docs ✅ Ready (Inspect) Visit Preview May 17, 2024 3:41pm

@OfTheDelmer OfTheDelmer requested a review from salilsub May 16, 2024 17:13
docs/k8s/user-guide.mdx Outdated Show resolved Hide resolved
docs/k8s/user-guide.mdx Outdated Show resolved Hide resolved
docs/k8s/user-guide.mdx Outdated Show resolved Hide resolved

### Composition

With a traffic policy designed for your production ingress use case you can easily add the policy and deploy with an annnotation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
With a traffic policy designed for your production ingress use case you can easily add the policy and deploy with an annnotation.
Traffic policies can be added to Ingress objects using annotations.

docs/k8s/user-guide.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@salilsub salilsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions.

Copy link
Contributor

@salilsub salilsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salilsub salilsub merged commit cfc0531 into main May 17, 2024
2 checks passed
@salilsub salilsub deleted the doc/add-trafficy-policy-doc branch May 17, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants