Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional rules to Traffic Policy gallery #773

Merged
merged 7 commits into from
Aug 22, 2024

Conversation

joelhans
Copy link
Contributor

@joelhans joelhans commented Jun 5, 2024

I got a request from Zubin to add the rules I created for this recent article directly into the existing rule gallery.

I also added a quick mention and link to said article, as it provides a bit more helpful context and a demo deployment for anyone who wants to try these configs out in a local development environment.

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ngrok-docs ✅ Ready (Inspect) Visit Preview Aug 22, 2024 4:35pm

@russorat
Copy link
Contributor

if you can resolve the conflicts, i will review and approve

@joelhans
Copy link
Contributor Author

Thanks @russorat! Looks like I cleared out the merge conflicts without breaking anything.

Copy link
Contributor

@russorat russorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@russorat
Copy link
Contributor

looks like there are still some conflicts somewhere. let me take a look at your branch

Signed-off-by: Russ Savage <[email protected]>
@russorat
Copy link
Contributor

alright, i think i fixed this

@russorat russorat merged commit 2a044ec into ngrok:main Aug 22, 2024
2 checks passed
@joelhans joelhans deleted the add-rule-gallery branch August 22, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants