Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating FastAPI Docs with a python-ngrok example #775

Merged
merged 10 commits into from
Jul 31, 2024
Merged

Updating FastAPI Docs with a python-ngrok example #775

merged 10 commits into from
Jul 31, 2024

Conversation

firecube-oss
Copy link
Contributor

  • This PR adds an example of how to use Ngrok with the ngrok-python SDK

@vercel Vercel
Copy link

vercel bot commented Jun 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ngrok-docs ✅ Ready (Inspect) Visit Preview Jul 31, 2024 5:44pm

@firecube-oss firecube-oss changed the title Firecube oss/updated fastapi docs Updating FastAPI Docs with a python-ngrok example Jun 6, 2024
salilsub
salilsub suggested changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@salilsub salilsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using pyngrok shouldn't be an option 2 since it isn't supported by ngrok. Using the SDK is the way to go, it should be the only option recommended in docs. If the suggested changes are made, will approve and merge.

russorat
russorat approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@russorat russorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you!

@russorat russorat merged commit 0b58d75 into ngrok:main Jul 31, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nijikokun nijikokun nijikokun left review comments

@salilsub salilsub salilsub requested changes

@russorat russorat russorat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@firecube-oss @nijikokun @russorat @salilsub