cookie and port variables fixes #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benjaminchan
commented
Jul 17, 2024
•
benjaminchan
commented
- fix cookie macros types and update description (to account for multiple cookies of same name) and example
- fix cookie variables types and update description (to account for multiple cookies of same name)
- add res.cookies[k][i].unparsed_attribute variable
- update req.url.port description (to call out what happens when port is implied)
- update req/res.cookie, req.url.host descriptions for http header templates variables
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rkolavo
reviewed
Jul 19, 2024
| @@ -85,7 +85,7 @@ The source of this data is subject to change. It is currently provided by [MaxMi | |||
| | `${req.content_type}` | The media type set in the Content-Type header for this request as a string. | | |||
| | `${req.content_type.parameters}` | The parameters set in the Content-Type header as a key value map. | | |||
| | `${req.content_type.raw}` | The Content-Type header for this request as a string. | | |||
| | `${req.cookies}` | The key value map of HTTP cookie objects provided in the request. | | |||
| | `${req.cookies}` | The key value map of HTTP cookie objects included in this request. If there are multiple cookies with the same name, they will be ordered as specified in the Cookie header. | | |||
There was a problem hiding this comment.
Is it the Set-Cookie header?
There was a problem hiding this comment.
Should be Cookie since that's the one used by clients in requests, whereas Set-Cookie is used by servers in responses
rkolavo
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.