Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERR_NGROK_3208 documentation and add details file #895

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

earl-ngrok
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ngrok-docs ✅ Ready (Inspect) Visit Preview Sep 24, 2024 4:14pm

@russorat
Copy link
Contributor

What is the reasoning for removing the section from the error message? if we want to do that, we will need to update the autogenerated error message.

@earl-ngrok
Copy link
Contributor Author

I moved the content to the "For Website Visitors" section thinking it fit better there, but I see the value in keeping it in the error message too. We can include it in both places and leave the original error message untouched if this works for you.

Copy link
Contributor

@russorat russorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russorat russorat merged commit c590142 into main Sep 24, 2024
2 of 3 checks passed
@russorat russorat deleted the update-err-ngrok-3208-docs-new branch September 24, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants