policy_engine: rename inbound/outbound to new phase names #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TheConcierge
force-pushed
the
ngrok/ryan/traffic-policy-phases
branch
from
9a77953
to
5ae3b5f
Compare
|
This looks good, I haven't had a chance to actually test the changes though. |
OKEAMAH
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates policy references from
inbound/outboundto the new phases:on_tcp_connect,on_http_request, andon_http_response.The one thing I'm unsure about is the Go SDK examples. I updated them to read from a file to match the other examples, but I'm unsure if there is a different way we want to present it.
NOTE: this does not include the API examples, as those are auto generated by a pipeline. I'll do that shortly after this merges.