Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(installation): add snippets for devtools-plugin #2077

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

OanaSurdea
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The devtools-plugin was referenced only in the yarn bulk install command and absent in the separate npm/yarn commands.

Issue Number: N/A

What is the new behavior?

The devtools-plugin snippet is available in both the yarn bulk install and the separate npm/yarn commands.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

N/A

benoitnesme and others added 2 commits September 26, 2023 21:56
The provide example doesn't compile and is misleading, especially because of the lack of [] around AnimalsState in @selector
Added snippet for installing the devtools plugin.
Copy link

nx-cloud bot commented Nov 4, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 54f562a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

Copy link

codeclimate bot commented Nov 4, 2023

Code Climate has analyzed commit 54f562a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.5% (0.0% change).

View more on Code Climate.

@markwhitfeld markwhitfeld merged commit d2f9ef4 into ngxs:master Nov 10, 2023
5 checks passed
Copy link

bundlemon bot commented Nov 10, 2023

BundleMon (Integration Projects)

Unchanged files (1)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng15/dist-integration/main.(hash)
.js
63.35KB +1%

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

markwhitfeld pushed a commit that referenced this pull request Nov 30, 2023
* docs: example code not compiling (#2059)

The provide example doesn't compile and is misleading, especially because of the lack of [] around AnimalsState in @selector

* Update installation.md

Added snippet for installing the devtools plugin.

---------

Co-authored-by: benoitnesme <[email protected]>
(cherry picked from commit d2f9ef4)
@markwhitfeld markwhitfeld added this to the v.18.0.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants