Hide Authentication method "Microsoft Active Directory" #12
Conversation
| @@ -16,6 +16,9 @@ const INJECTED_HTML = ` | |||
| /* hide everything having the BE Feature banner */ | |||
| .be-indicator-container, .limited-be {display: none !important;} | |||
|
|
|||
| /* hide Authentication method "Microsoft Active Directory" */ | |||
| .app-react-components-BoxSelector-BoxSelectorItem-module__business {display: none !important;} | |||
There was a problem hiding this comment.
Thanks for the contribution. However, I'm a bit doubt that this is an auto-generated class name, so I'm not sure if it will changed soon in one of the next versions.
I'm wondering if we can find a better selector here. Maybe based on nth-child, or ideally just a simple name like all other selectors?
There was a problem hiding this comment.
I don't see a problem. But I must admit I do not know Portainer's HTML+CSS so well. I installed the software a couple of times and used it (before the whole BE stuff).
I would not recommend nth-child or something positional, because this can break easily. Also I noticed after creating the PR, that my rule not only eliminates the one box I show in the screenshot, but also a couple more further at the bottom, depending what authentication method you select.
Do you think the BoxSelector-BoxSelectorItem is auto-generated because of uppercase letters? Does look like a legitimate name (ok a stupid name because of mixing snake and camel cases 🙈 ), but not special/auto-generated/about to change soon.
There was a problem hiding this comment.
Since portainer is open source, you can have a look at the source code to see where the class name comes from:
The class name is indeed transformed (rather than generated), so I assume that it won't change in near future.
If we want a bit more future-proof, I'd suggest matching all classes [class*="BoxSelectorItem-module__business"], what do you think?
Hey, thanks for your work 😄
Just stumbled over portainer/portainer#8452 (comment) and found your project. Tried it out, but I still found something BE-related. This PR should fix that.
Before:
After:
Have a look, I just tried the CSS rule live in the browser without building the whole Docker image.