Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH3530: Add locale specific tests to check for invalid type conversions. #3548

Open
wants to merge 54 commits into
base: master
Choose a base branch
from

Commits on Jun 10, 2024

  1. GH3530: Add locale specific tests to check for invalid type conversions.

    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    f3fe3d2 View commit details
    Browse the repository at this point in the history
  2. nhibernateGH-3530: Change id type in preparation for manually creatin…

    …g the schema.
    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    2c8adc1 View commit details
    Browse the repository at this point in the history
  3. nhibernateGH-3530: Attempt to manually create the schema using the cu…

    …rrent dialect.
    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    1a29463 View commit details
    Browse the repository at this point in the history
  4. nhibernateGH-3530: Add missing comma and space after Id field.

    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    af82e96 View commit details
    Browse the repository at this point in the history
  5. nhibernateGH-3530: Use the same syntax as Table.SqlCreateString for t…

    …he identity column.
    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    c62a7e8 View commit details
    Browse the repository at this point in the history
  6. nhibernateGH-3530: Break up the tests by type so we can see which typ…

    …es fail where.
    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    1394492 View commit details
    Browse the repository at this point in the history
  7. nhibernateGH-3530: Fix incorrect test for Double types.

    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    72367b2 View commit details
    Browse the repository at this point in the history
  8. nhibernateGH-3530: Add a meaningful message when TestDouble fails.

    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e66e1c6 View commit details
    Browse the repository at this point in the history
  9. nhibernateGH-3530: Attempt to switch to a guid Id as some databases d…

    …o not support the identity generator.
    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    a9b0910 View commit details
    Browse the repository at this point in the history
  10. nhibernateGH-3530: Guid key's are not identity columns and are define…

    …d like all other columns.
    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    5282ab3 View commit details
    Browse the repository at this point in the history
  11. nhibernateGH-3530: Correctly add the primary key constraint for the I…

    …d column.
    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    11d645e View commit details
    Browse the repository at this point in the history
  12. nhibernateGH-3530: Allow all properties of the LocaleEntity to be nul…

    …lable.
    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    aa7cd99 View commit details
    Browse the repository at this point in the history
  13. nhibernateGH-3530: Separate the types into different tables to avoid …

    …failure on default values.
    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    2666a44 View commit details
    Browse the repository at this point in the history
  14. Generate async files

    github-actions[bot] authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    d10c4d8 View commit details
    Browse the repository at this point in the history
  15. nhibernateGH-3530: Remove trailing comma and space from last column i…

    …n table generation.
    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    fd4f95c View commit details
    Browse the repository at this point in the history
  16. Generate async files

    github-actions[bot] authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    956219f View commit details
    Browse the repository at this point in the history
  17. nhibernateGH-3530: Rename the Value column to DataValue to avoid conf…

    …licts with reserved words.
    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    7ec4e58 View commit details
    Browse the repository at this point in the history
  18. Generate async files

    github-actions[bot] authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    6461ddd View commit details
    Browse the repository at this point in the history
  19. nhibernateGH-3530: Add additional test that uses the DateTime type wi…

    …th the
    
    dilect's suggested type.
    
    Perform some minor cleanup recommended by the DeepSource analysis.
    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e09ffe6 View commit details
    Browse the repository at this point in the history
  20. Generate async files

    github-actions[bot] authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    c2c7bd5 View commit details
    Browse the repository at this point in the history
  21. nhibernateGH-3530: Let the SchemaExporter drop and create tables befo…

    …re attempting to create them manually.
    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    ea81464 View commit details
    Browse the repository at this point in the history
  22. Generate async files

    github-actions[bot] authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    06edc33 View commit details
    Browse the repository at this point in the history
  23. nhibernateGH-3530: Add exception handler to handle cases when the tab…

    …le already exists.
    
    Partially revert part of the previous commit which changed the responisbility
    of the SchemaExporter. Hopefully this fixes failing tests due to schema issues.
    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    91f2599 View commit details
    Browse the repository at this point in the history
  24. Generate async files

    github-actions[bot] authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    f9575cb View commit details
    Browse the repository at this point in the history
  25. GH-5350: Rename Entity<T> to DataEntity<T> to address Deepsource issue.

    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    a2cf98c View commit details
    Browse the repository at this point in the history
  26. GH-5350: Use StringBuilder.Append(char) for appending a single charac…

    …ter.
    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    f1661eb View commit details
    Browse the repository at this point in the history
  27. nhibernateGH-3530: Switch to simple using statements per Deepsource.

    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    36b951e View commit details
    Browse the repository at this point in the history
  28. nhibernateGH-3530: Switch to file scoped namespacing per Deepsource.

    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    2e3206f View commit details
    Browse the repository at this point in the history
  29. nhibernateGH-3530: Replace explicit type with var to avoid type dupli…

    …cation.
    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    8625f25 View commit details
    Browse the repository at this point in the history
  30. Generate async files

    github-actions[bot] authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    58fe6c7 View commit details
    Browse the repository at this point in the history
  31. nhibernateGH-3530: Switch to file scoped namespace per DeepSource.

    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    2be793d View commit details
    Browse the repository at this point in the history
  32. GH-5350: Add global setting for specifying the locale of the database.

    David Ellingsworth authored and David Ellingsworth committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    ac708f6 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. nhibernateGH-3530: Use type specific methods of DbDataReader where po…

    …ssible and
    
    use Convert with the user provided locale if necessary.
    David Ellingsworth authored and David Ellingsworth committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    bb38501 View commit details
    Browse the repository at this point in the history
  2. nhibernateGH-3530: Fix failing BooleanType test due to changed behavi…

    …or of the BooleanType.
    David Ellingsworth authored and David Ellingsworth committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    6dbd4f0 View commit details
    Browse the repository at this point in the history
  3. nhibernateGH-3530: Fix failing CharBooleanType test due to change in …

    …behavior of the CharBooleanType.
    David Ellingsworth authored and David Ellingsworth committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    97a516d View commit details
    Browse the repository at this point in the history
  4. nhibernateGH-3530: Add tests for float type.

    David Ellingsworth authored and David Ellingsworth committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    f8eb2a6 View commit details
    Browse the repository at this point in the history
  5. nhibernateGH-3530: Add a mechanism to Drivers to execute a command an…

    …d return a DbDataReader.
    David Ellingsworth authored and David Ellingsworth committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    445d5a9 View commit details
    Browse the repository at this point in the history
  6. nhibernateGH-3530: Add a class for wrapping a DbDataReader.

    David Ellingsworth authored and David Ellingsworth committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    fa84e8a View commit details
    Browse the repository at this point in the history
  7. nhibernateGH-3530: Add a DbDataReader for performing direct casts of …

    …values returned from the indexer method.
    David Ellingsworth authored and David Ellingsworth committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    f135115 View commit details
    Browse the repository at this point in the history
  8. nhibernateGH-3530: Add TypeOfConnection and TypeOfCommand properties …

    …to the ReflectionBasedDriver to allow derived classes to access the type information.
    David Ellingsworth authored and David Ellingsworth committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    4da33b7 View commit details
    Browse the repository at this point in the history
  9. nhibernateGH-3530: The Oracle driver does not support DbDataReader.Ge…

    …tChar and does not convert strings to datetime values. Add a custom OracleDbDataReader to address these issues.
    David Ellingsworth authored and David Ellingsworth committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    b6b55f4 View commit details
    Browse the repository at this point in the history
  10. nhibernateGH-3530: The MySql driver doesn't properly convert strings …

    …from the database to decimal types. Add a MySqlDbDataReader to correct this deficiency.
    David Ellingsworth authored and David Ellingsworth committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    ec49d5f View commit details
    Browse the repository at this point in the history
  11. nhibernateGH-3530: Firebird incorrectly uses the current culture to c…

    …onvert dates stores as strings. Address this issue by adding a FirebirdDbDataReader.
    David Ellingsworth authored and David Ellingsworth committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    4b010ce View commit details
    Browse the repository at this point in the history
  12. nhibernateGH-3530: Many drivers lack support for the DbDataReader.Get…

    …Char method. Add a NoCharDbDataReader to use with these drivers.
    David Ellingsworth authored and David Ellingsworth committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    de669f2 View commit details
    Browse the repository at this point in the history
  13. nhibernateGH-3530: The Sql Server 2008 driver lacks support for the D…

    …bDataReader.GetChar method, wrap it in a NoCharDbDataReader.
    David Ellingsworth authored and David Ellingsworth committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    adf1f01 View commit details
    Browse the repository at this point in the history
  14. nhibernateGH-3530: The MicrosoftDataSqlClientDriver does not support …

    …the DbDataReader.GetChar method, wrap it with the NoCharDbDataReader.
    David Ellingsworth authored and David Ellingsworth committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    6e49aac View commit details
    Browse the repository at this point in the history
  15. nhibernateGH-3530: The SAP SQL Anywhere driver does not support the D…

    …bDataReader.GetChar method, wrap it in the NoCharDbDataReader.
    David Ellingsworth authored and David Ellingsworth committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    6610fe2 View commit details
    Browse the repository at this point in the history
  16. nhibernateGH-3530: The Sql Server CE driver does not support the DbDa…

    …taReader.GetChar method, wrap it in the NoCharDbDataReader.
    David Ellingsworth authored and David Ellingsworth committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    b99474d View commit details
    Browse the repository at this point in the history
  17. nhibernateGH-3530: Ensure all DbDataReader.TryGet extention methods c…

    …atch all types of exceptions.
    David Ellingsworth authored and David Ellingsworth committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    f8637c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. nhibernateGH-3530: Add a warning when a driver throws an exception wh…

    …ile retrieving a value.
    David Ellingsworth authored and David Ellingsworth committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    b94e807 View commit details
    Browse the repository at this point in the history
  2. nhibernateGH-3530: The SAP SqlAnywhere driver does not implement DbDa…

    …taReader.GetChar and incorrectly uses Convert without specifying an IFormatProvider. Wrap the SAP SqlAnywhere DbDataReader in a SqlAnywhereDbDataReader to correct these issues.
    David Ellingsworth authored and David Ellingsworth committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    2b8c35e View commit details
    Browse the repository at this point in the history
  3. nhibernateGH-3530: The Sybase SqlAnywhere DotNet4 driver does not imp…

    …lement DbDataReader.GetChar and incorrectly uses Convert without specifying an IFormatProvider. Wrap the Sybase SqlAnywhere DotNet4 DbDataReader in a SqlAnywhereDbDataReader to correct these issues.
    David Ellingsworth authored and David Ellingsworth committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    dff6329 View commit details
    Browse the repository at this point in the history
  4. nhibernateGH-3530: The Sybase SqlAnywhere driver does not implement D…

    …bDataReader.GetChar and incorrectly uses Convert without specifying an IFormatProvider. Wrap the Sybase SqlAnywhere DbDataReader in a SqlAnywhereDbDataReader to correct these issues.
    David Ellingsworth authored and David Ellingsworth committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    5c022a5 View commit details
    Browse the repository at this point in the history
  5. nhibernateGH-3530: Add an extension method to specify the return type…

    …s when calling DbDataReader.GetValues()
    David Ellingsworth authored and David Ellingsworth committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    0563713 View commit details
    Browse the repository at this point in the history