Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH3618 - Failed recognition of SQL comments #3637

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

GH3618 - Failed recognition of SQL comments #3637

wants to merge 4 commits into from

Conversation

gliljas
Copy link
Member

@gliljas gliljas commented Jan 2, 2025

@fredericDelaporte fredericDelaporte added this to the 5.6 milestone Jan 5, 2025
fredericDelaporte
fredericDelaporte previously approved these changes Jan 5, 2025
View reviewed changes
Copy link
Member

@fredericDelaporte fredericDelaporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some old redundant code could be slightly optimized by the way, but LGTM.

src/NHibernate/Engine/Query/ParameterParser.cs Outdated Show resolved Hide resolved
src/NHibernate/Engine/Query/ParameterParser.cs Outdated Show resolved Hide resolved
src/NHibernate/Engine/Query/ParameterParser.cs Outdated Show resolved Hide resolved
src/NHibernate/Engine/Query/ParameterParser.cs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericDelaporte fredericDelaporte fredericDelaporte approved these changes

Assignees
No one assigned
Labels
t: Fix
Projects
None yet
Milestone
5.6
Development

Successfully merging this pull request may close these issues.
2 participants
@gliljas @fredericDelaporte