-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and bump version on each package #109
base: main
Are you sure you want to change the base?
Conversation
@ninogjoni Thank you for the PR, it looks pretty ok, but there are lots of formatting changes that are not really necessary for this PR, can you ensure that those are fixed? also please take care of the failed CI checks. |
@mhadaily I corrected things and did an analysis locally beforehand with |
Awesom, thank you, I will merge this and publish a new version soon |
Hi, can we update it to http 1.1.0 instead? |
|
Hey @ninogjoni I am sorry again but I tried to start reviewing and merge this PR but it looks like now we have lots of conflicts on your branch. can you take a look? |
Hi
Can you just check the unchanged file from git? Let’s not have formatting
in the PR
And you should upgrade your package again and consider latest versions that
I just published and bump based on that
On Tue, 29 Aug 2023 at 20:24, Nino Gjoni ***@***.***> wrote:
Hi @mhadaily <https://github.com/mhadaily>
There were still my auto formatting changes in the workflows... Also,
three packages have already been updated to x.x.1 (see #102
<#102>) didn't know now if my
changes could also go in there. Or will there be conflicts with pub.dev?
—
Reply to this email directly, view it on GitHub
<#109 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKDTCYWHJJAWUDGUHB2YHLXXYXUXANCNFSM6AAAAAA3FQBOGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Best regards, *
Majid
|
Hey,
I was sure that I had already undone the formatting (apparently I did
not...) My mistake, sorry! Hopefully I've reversed the workflow files
properly and updated the versions now, made a PR.
Best regards,
Nino
… Hi
Can you just check the unchanged file from git? Let’s not have
formatting
in the PR
And you should upgrade your package again and consider latest
versions that
I just published and bump based on that
On Tue, 29 Aug 2023 at 20:24, Nino Gjoni ***@***.***> wrote:
> Hi @mhadaily <https://github.com/mhadaily>
>
> There were still my auto formatting changes in the workflows...
Also,
> three packages have already been updated to x.x.1 (see #102
> <#102>) didn't know now if
my
> changes could also go in there. Or will there be conflicts with
pub.dev?
>
> —
> Reply to this email directly, view it on GitHub
>
<#109 (comment)>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AAKDTCYWHJJAWUDGUHB2YHLXXYXUXANCNFSM6AAAAAA3FQBOGY>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
*Best regards, *
Majid
--
Reply to this email directly, view it on GitHub [1], or unsubscribe
[2].
You are receiving this because you were mentioned.Message ID:
***@***.***>
Links:
------
[1]
#109 (comment)
[2]
https://github.com/notifications/unsubscribe-auth/ALYJA6VEOJWGXNLLJLY5JQDXXY2PXANCNFSM6AAAAAA3FQBOGY
|
No description provided.