Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Cloudflare Turnstile response param in signUp (#155) #156

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

wildsurfer
Copy link
Contributor

@wildsurfer wildsurfer commented Dec 7, 2024

Fixes #155

@wildsurfer wildsurfer force-pushed the main branch 2 times, most recently from 561d4d4 to a367317 Compare December 7, 2024 17:06
@wildsurfer wildsurfer changed the title feat: add support for Cloudflare Turnstile response param in signInWithEmailPasswordless (#155) feat: add support for Cloudflare Turnstile response param in signUp (#155) Dec 7, 2024
@dbarrosop
Copy link
Member

Thanks for the PR, just a minor comment, otherwise, LGTM :)

@wildsurfer
Copy link
Contributor Author

@dbarrosop I implemented your recommendations, let me know if you wnat anything else please

@dbarrosop
Copy link
Member

dbarrosop commented Dec 13, 2024

@wildsurfer
Copy link
Contributor Author

@dbarrosop 🤔 It was already enabled...
Screenshot 2024-12-13 at 11 47 59

image

@dbarrosop
Copy link
Member

I will never understand github...

git push [email protected]:wildsurfer/nhost-dart.git wildsurfer-main
Enumerating objects: 9, done.
Counting objects: 100% (9/9), done.
Delta compression using up to 14 threads
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 528 bytes | 176.00 KiB/s, done.
Total 5 (delta 3), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (3/3), completed with 3 local objects.
To github.com:wildsurfer/nhost-dart.git
 ! [remote rejected] wildsurfer-main -> wildsurfer-main (permission denied)
error: failed to push some refs to 'github.com:wildsurfer/nhost-dart.git'

anyway, it is a simple fix so maybe it is faster if you do it yourself, edit the file .github/workflows/test.nhost_auth_dart.yaml and apply the following patch:

diff --git a/.github/workflows/test.nhost_auth_dart.yaml b/.github/workflows/test.nhost_auth_dart.yaml
index afacf73..8ad5a5f 100644
--- a/.github/workflows/test.nhost_auth_dart.yaml
+++ b/.github/workflows/test.nhost_auth_dart.yaml
@@ -22,7 +22,8 @@ on:
 # Run the quality job at 4am every day
 # - cron: '0 4 * * *'

-env: {}
+env:
+  MAX_PANA_MISSING_POINTS: 40
 jobs:
   # Ensure that the package meets a suitably high pub.dev score
   score-package-quality:

@wildsurfer
Copy link
Contributor Author

@dbarrosop patch applied 🙂

@dbarrosop
Copy link
Member

Thanks! Merging.

@dbarrosop dbarrosop merged commit e636019 into nhost:main Dec 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nhost_auth_dart package doesn't support Cloudflare Turntile bot protection
2 participants