Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repository_migrator.py to fix Repository capture and migration feature #148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NurAb-Sal
Copy link

Fixes Issue #147: "Service 'PackageRepository' cannot be migrated because the specified service is not installed locally."

The service definition json for the package repository is %PROGRAMDATA%/Skyline/Config/Repository.json", which fails to match the RepositoryMigrator.name = "PackageRepository" property -> hence the service fails to be found by the module.

  • This contribution adheres to CONTRIBUTING.md.
    TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.

What does this Pull Request accomplish?
TODO: Fixes capture and migrate features for the Repository service.

Why should this Pull Request be merged?
TODO: Fix issue #147

What testing has been done?
TODO: Tested successfully with SystemLink Server 21.0. Should hold true for any newer SystemLink Server instance with installed Repository service.

Fixes Issue [ni#147](ni#147):
"Service 'PackageRepository' cannot be migrated because the specified service is not installed locally."

The service definition json for the package repository is %PROGRAMDATA%/Skyline/Config/Repository.json", which fails to match the RepositoryMigrator.name = "PackageRepository" property -> hence the service fails to be found by the module.
@Christian-Nunnally
Copy link
Collaborator

This will break migrating SL 21+ because the package repository service configuration file got renamed to PackageRepository.

Perhaps to fix your issue you can copy Package.json and rename it to PackageRepository.json so the the migration tool has something to find? I'm not sure if the repository files also live in a different location on that version of SL.

Copy link
Collaborator

@Christian-Nunnally Christian-Nunnally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service got renamed between SL v20 and v21, so this will fix your issue but break migrations to/from later versions of SL.

@NurAb-Sal
Copy link
Author

Good to know. In that case we could just add an OR function to match all versions.

@JD-Robertson
Copy link
Contributor

Good to know. In that case we could just add an OR function to match all versions.

We only document support for 21.0+. There are likely other compatibility issues with migrating 20.x verions of SystemLink with this tool.

@NurAb-Sal
Copy link
Author

The upgrade was from 21.0 to 22Q3. According to the README.md, 21.0 as a source version should be supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants