Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new DFS values for kafkaless ingestion and disabling kafka #165

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Add new DFS values for kafkaless ingestion and disabling kafka #165

merged 5 commits into from
Sep 26, 2023

Conversation

kjohn1922
Copy link
Contributor

What does this Pull Request accomplish?

  • Add values related to disabling Kafka. We have decided to document the procedure and caveats for disabling Kafka in the release notes, so the comments point to the release notes for 2023-10 for more information
  • requestBodySizeLimitMegabytes renamed to requestBodySizeLimit, now accepts MB and MiB (added to the Helm Breaking Changes spreadsheet here.)
  • Document some of the values related to S3 ingestion that the customer may need to tweak.

Why should this Pull Request be merged?

Documenting new DFS values.

What testing has been done?

None

spanglerco
spanglerco approved these changes Sep 25, 2023
View reviewed changes
getting-started/templates/systemlink-values.yaml Outdated Show resolved Hide resolved
getting-started/templates/systemlink-values.yaml Outdated Show resolved Hide resolved
@kjohn1922 kjohn1922 merged commit b522b9a into main Sep 26, 2023
2 checks passed
@kjohn1922 kjohn1922 deleted the users/kelseyj/dfs-values branch September 26, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JD-Robertson JD-Robertson JD-Robertson approved these changes

@spanglerco spanglerco spanglerco approved these changes

@prestwick prestwick Awaiting requested review from prestwick prestwick is a code owner

@BKnight760 BKnight760 Awaiting requested review from BKnight760 BKnight760 is a code owner

@lnowotny lnowotny Awaiting requested review from lnowotny lnowotny is a code owner

@Christian-Nunnally Christian-Nunnally Awaiting requested review from Christian-Nunnally Christian-Nunnally is a code owner

@MelissaHilliard MelissaHilliard Awaiting requested review from MelissaHilliard MelissaHilliard is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjohn1922 @spanglerco @JD-Robertson