This repository has been archived by the owner on Jan 9, 2021. It is now read-only.
Better Visual Studio and Windows support. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But over the years stuff was put in the wrong place. Pull those out of the cURL dependancies. Also, you cannot reap cURLs if they're not there.
Hurrah! It was about time.
For some reason sgminer is compiled as c++ app in VS. Now, VS2017 supports user defined literals but it cannot figure out of something is a literal or a macro to be expanded so help its parsers. There's nothing really wrong with spaces every once in a while btw.
It would be best to pass all the config as command line params but hey..
…led through references. Upgrade jansson to use right snprintf
…ll in VS2015 TLS.
Wsock sucks but that's not a good excuse for not driving them correctly. It happens windows still exists so get along with it, IDK how many times I applied this patch privately; it stops being funny after a while.
|
Any progress? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason this is compiled as C++ code in Visual Studio. A lot of changes involve safe casting from/to uints.
Fixed a typo in blake.c
Added plenty of missing .c files
cURL should really be an optional dependancy, as is SSL. Having it optional greatly simplifies compile: now one just has to download this, ptheads and hit go debug.
Arguably correct windows socket init & shutdown.
jansson dependancy as vs reference instead of pragma, it seems other build systems would be better off specifying additional link.
Added missing lib, update to latest windows sdk.
Someone should really test yescrypt, in case someone is interested in GPU mining it (but WHY?).