Bump to LibreHardwareMonitor 0.9.3 #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a breaking change in LHW with the [introduction of the index of superIO identifier][0]: Before: ``` /lpc/nct6792d/control/0 "Fan #1" ``` After: ``` /lpc/nct6792d/0/control/0 "Fan #1" ``` I'm open to discussion on what the right course of action should be: 1. Preserve the breaking change and just note it in the changelog 2. Introduce logic to keep the same sensor IDs (but what to do with new users with systems that eventually see the motherboard hardware split in two, which would experience duplicate sensor IDs or a breaking change in IDs if we only introduced indices if multiple exist). 3. Introduce a config in OhmGraphite so the user can choose between 1 and 2 (and default to 2) Another use visible change is that there is a new metric for storage metrics: "Read Activity" which is analogous to the already present Total and Write Activity sensors but for reading. [0]: LibreHardwareMonitor/LibreHardwareMonitor#1183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a breaking change in LHW with the introduction of the index of superIO identifier:
Before:
After:
I'm open to discussion on what the right course of action should be:
Preserve the breaking change and just note it in the changelogIntroduce a config in OhmGraphite so the user can choose between 1 and 2 (and default to 2)Option "2" was chosen as it allows us to punt the decision down the road in a "wait and see" scenario.
Another user visible change is that there is a new metric for storage metrics: "Read Activity" which is analogous to the already present Total and Write Activity sensors but for reading.