Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Power Draw with AMD GPU #465

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Conversation

swiffer
Copy link
Contributor

@swiffer swiffer commented Nov 5, 2024

  • 18b1059 fixes calculation of power draw with amd gpu
  • 92764ca fixes gpu load / memory load with amd gpu and excludes distance to tjmax (negative temperatures, not really useful imho)
  • 15fd0c5 removes additional config entry after filtering out distance to tjmax temps
  • 7976aa5 updates the dashboard with latest schema from grafana 11.3.0 and fixes some panels that had invalid settings configured for repeat

@nickbabcock
Copy link
Owner

Thanks for the contribution, any context/screenshots behind the change?

@swiffer
Copy link
Contributor Author

swiffer commented Nov 7, 2024

hi @nickbabcock - sorry missed to add a description - i hoped to have commit messages that are explaining the changes.

overall it's about fixing some falsly configured panel repeat settings, metric fixes with amd gpu, excluding distance to tjmax from temps and keeping the dashboard updated with grafana 11.3.0.

@nickbabcock
Copy link
Owner

Tried it out, looks good! Thank you

When I updated to grafana 11.3.0, it broke the layout of the existing dashboard -- sounds like grafana must have had some changes in layout calculations from grafana 10 to 11.

So unless you want to, I'll follow this PR up with one to restore side by side charts so they aren't so wide.

@swiffer
Copy link
Contributor Author

swiffer commented Nov 12, 2024

Yes, that was actually the reason why I started changing things ;)

Would be great if you could take over realignment of graphs to side-by-side - guess I mixed up the order and currently have no chance to compare vs. grafana 10.

@nickbabcock nickbabcock merged commit 49e86ef into nickbabcock:master Nov 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants