Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate vote actor support #191

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Reinstate vote actor support #191

merged 1 commit into from
Dec 31, 2024

Conversation

nickbabcock
Copy link
Owner

In #185 I deleted code (shown below) that fell back on the class hierarchy described in the replay instead of the ones we hardcode. Turns out, when running a regression test against the main replay corpus of 200k replays files -- 2 replays depended on this fallback being present. I've hard coded the missing vote actor, but the main thing is adding the regression replay to the codebase so this doesn't happen again in the future.

boxcars/src/network/mod.rs

Lines 139 to 152 in 45d0cc1

// Sometimes our hierarchy set up in build.rs isn't perfect so if we don't find a
// parent and a parent cache id is set, try and find this parent id and carry down
// their props.
if !had_parent && cache.parent_id != 0 {
if let Some(parent) = body
.net_cache
.iter()
.find(|x| x.cache_id == cache.parent_id)
{
if let Some(parent_attrs) = object_ind_attrs.get(&ObjectId(parent.object_ind)) {
all_props.extend(parent_attrs.iter());
}
}
}

In #185 I deleted code that fell back on the class hierarchy described
in the replay instead of the ones we hardcode. Turns out, when running a
regression test against the main replay corpus of 200k replays files --
2 replays depended only successfully parsed if this fallback was
present. I've added the hard coded the missing vote actor, but the main
thing is the adding the regression replay to the codebase so this
doesn't happen again in the future.

0ce77fd#diff-bc565c9df4b377f07d29b6132b181f1a239dfd8acab3700841961ed4550f8975L139-L150
@nickbabcock nickbabcock merged commit ed8e0fb into master Dec 31, 2024
9 checks passed
@nickbabcock nickbabcock deleted the vote branch December 31, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant