Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #185 I deleted code (shown below) that fell back on the class hierarchy described in the replay instead of the ones we hardcode. Turns out, when running a regression test against the main replay corpus of 200k replays files -- 2 replays depended on this fallback being present. I've hard coded the missing vote actor, but the main thing is adding the regression replay to the codebase so this doesn't happen again in the future.
boxcars/src/network/mod.rs
Lines 139 to 152 in 45d0cc1