Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimized code in some places #838

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

optimized code in some places #838

wants to merge 2 commits into from

Conversation

GeorgCantor
Copy link

@GeorgCantor GeorgCantor commented Sep 4, 2020 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Replaced null check with operator let;
Replaced if with with operator.

💡 Motivation and Context

This improves the readability and elegance of the code.
And reduces the amount of code

💚 How did you test it?

📝 Checklist

  • I ran ./gradlew spotlessApply before submitting the PR
  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

📸 Screenshots / GIFs

@codingjeremy codingjeremy changed the base branch from master to main September 29, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeorgCantor @googlebot