Refine vertex normal optimisation checks #127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposal to remove the polygon face normal inequality check when calling
hasVertexNormals
as suggested in Issue 125This aims to solve use cases where face normals are not included when creating
SCNGeometry
instances from aMesh
in instances where the vertex normals are equal to the polygons plane normal.Discussion
I have removed the offending clause from the
hasVertexNormals
and updated the failing unit tests accordingly.The following unit tests have been removed as these are no longer necessary;
testMeshWithoutVertexNormals
testExportSphereWithoutTexcoordsOrNormals
I had considered extending these by replacing calls to
smoothingNormals(:)
with awithoutNormals()
equivalent but these would only flag up the assertions for non-zero normal values when initialising a polygon so these tests have instead been removed in favour of brevity.