Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum supported Swift version to Swift 5.7 #1837

Draft
wants to merge 52 commits into
base: develop
Choose a base branch
from
Draft

Update minimum supported Swift version to Swift 5.7 #1837

wants to merge 52 commits into from

Commits on Aug 24, 2024

  1. --conditionswrap option to format condition in Xcode 12 style, in c… 

    …ase it's too long or multiline
    @nicklockwood
    a.baranouski authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    e5692e1 View commit details
    Browse the repository at this point in the history

  2. Add preferInferredTypes rule

    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    44d79dd View commit details
    Browse the repository at this point in the history

  3. Make preferInferredTypes rule more compatible with redundantType rule

    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    2b8d27d View commit details
    Browse the repository at this point in the history

  4. Extend preferInferredTypes rule to support if/switch expressions

    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    b873d7d View commit details
    Browse the repository at this point in the history

  5. Fix issue where preferInferredTypes would cause build failure if prop… 

    …erty has optional type
    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    0bf5531 View commit details
    Browse the repository at this point in the history

  6. Fix issue where preferInferredTypes could cause a build failure if th… 

    …e property's type is an existential, or if the RHS value has an infix operator
    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    08d52d5 View commit details
    Browse the repository at this point in the history

  7. Update preferInferedTypes rule to propertyType, add support for expli… 

    …cit option
    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    19e2685 View commit details
    Browse the repository at this point in the history

  8. Alphabetically sort organized declarations by name pattern

    @nicklockwood
    Ryzhov Evgeniy Igorevich authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    dc52243 View commit details
    Browse the repository at this point in the history

  9. Support automatic sorting by name pattern for sortDeclarations rule (… 

    …nicklockwood#1731)
    @oiuhr @nicklockwood
    oiuhr authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    4667e23 View commit details
    Browse the repository at this point in the history

  10. Add SwiftUI Property Wrapper declaration type (nicklockwood#1747)

    @miguel-jimenez-0529 @nicklockwood
    miguel-jimenez-0529 authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    152da3a View commit details
    Browse the repository at this point in the history

  11. Include original token range when parsing declarations (nicklockwood#… 

    …1759)
    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    fe644d5 View commit details
    Browse the repository at this point in the history

  12. Add unusedPrivateDeclaration rule to remove unused private and filepr… 

    …ivate declarations (nicklockwood#1750)

Co-authored-by: Cal Stephens <[email protected]>
    @mannylopez @calda @nicklockwood
    2 people authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    6fe2247 View commit details
    Browse the repository at this point in the history

  13. organizeDeclarations custom naming & ordering (nicklockwood#1736)

    @oiuhr @nicklockwood
    oiuhr authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    9f29782 View commit details
    Browse the repository at this point in the history

  14. Add allowList to unusedPrivateDeclaration (nicklockwood#1761)

    @mannylopez @nicklockwood
    mannylopez authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    51b369a View commit details
    Browse the repository at this point in the history

  15. Improve expressiveness of --typeorder and --visibilityorder options (n… 

    …icklockwood#1760)
    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    4781d16 View commit details
    Browse the repository at this point in the history

  16. Add typealias to unusedPrivateDeclaration allowlist (nicklockwood#1764)

    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    758d010 View commit details
    Browse the repository at this point in the history

  17. Add docCommentBeforeAttributes rule (nicklockwood#1766)

    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    4f76454 View commit details
    Browse the repository at this point in the history

  18. Improve code organization of organizeDeclarations rule and related he… 

    …lpers (nicklockwood#1765)
    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    c26282b View commit details
    Browse the repository at this point in the history

  19. Fix build of CommandLineTool product

    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    bbe2bee View commit details
    Browse the repository at this point in the history

  20. Improve docCommentsBeforeAttributes rule, fix support for declaration… 

    …s after MARK comments (nicklockwood#1770)
    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    435ce82 View commit details
    Browse the repository at this point in the history

  21. Fix parseDeclarations bug where incorrect tokens could cause rules to… 

    … time out (nicklockwood#1769)
    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    5cb234f View commit details
    Browse the repository at this point in the history

  22. Update unusedPrivateDeclaration and handle false positives (nicklockw… 

    …ood#1771)
    @mannylopez @nicklockwood
    mannylopez authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    c74333a View commit details
    Browse the repository at this point in the history

  23. Update docCommentsBeforeAttributes rule to only apply to doc comments (… 

    …nicklockwood#1773)
    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    a9507a1 View commit details
    Browse the repository at this point in the history

  24. Add exceptions to unusedPrivateDeclaration rule (nicklockwood#1779)

    @mannylopez @nicklockwood
    mannylopez authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    a3005a7 View commit details
    Browse the repository at this point in the history

  25. Fix FocusState typo (nicklockwood#1785)

    @miguel-jimenez-0529 @nicklockwood
    miguel-jimenez-0529 authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    2172c0a View commit details
    Browse the repository at this point in the history

  26. Implement each rule in a separate file (nicklockwood#1782)

    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    d79cb43 View commit details
    Browse the repository at this point in the history

  27. Update exclude to reference rules using static member lookup (nickl… 

    …ockwood#1787)
    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    8ae2da9 View commit details
    Browse the repository at this point in the history

  28. Implement tests for each rule in a separate file (nicklockwood#1789)

    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    e4947df View commit details
    Browse the repository at this point in the history

  29. Update organizeDeclarations to avoid inserting blank lines inside con… 

    …secutive groups of properties (nicklockwood#1795)
    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    a23b916 View commit details
    Browse the repository at this point in the history

  30. Ensure SwiftUI property reorder doesn't affect synthesized init (nick… 

    …lockwood#1796)
    @miguel-jimenez-0529 @nicklockwood
    miguel-jimenez-0529 authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    1fd1040 View commit details
    Browse the repository at this point in the history

  31. Add emptyExtension rule + tests (nicklockwood#1792)

    @mannylopez @nicklockwood
    mannylopez authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    6a43b76 View commit details
    Browse the repository at this point in the history

  32. Fix issue where closing brace could turn into a comment unexpectedly (n… 

    …icklockwood#1797)
    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    657bb1d View commit details
    Browse the repository at this point in the history

  33. Move rule-specific helpers from DeclarationHelpers.swift to OrganizeD… 

    …eclarations.swift, improve shared helpers (nicklockwood#1798)
    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    593c31c View commit details
    Browse the repository at this point in the history

  34. Add SwiftUI properties subcategory alphabetical sort (nicklockwood#1794)

    @miguel-jimenez-0529 @nicklockwood
    miguel-jimenez-0529 authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    c4f7823 View commit details
    Browse the repository at this point in the history

  35. [New rule] spacingGuards (nicklockwood#1804)

    @NikKovIos @nicklockwood
    NikKovIos authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    ce9af67 View commit details
    Browse the repository at this point in the history

  36. Add test case to unusedPrivateDeclaration (nicklockwood#1805)

    @mannylopez @nicklockwood
    mannylopez authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    c01d68e View commit details
    Browse the repository at this point in the history

  37. Updated readme about how to test own rule. (nicklockwood#1807) 

    Co-authored-by: Cal Stephens <[email protected]>
    @NikKovIos @calda @nicklockwood
    2 people authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    651b4d0 View commit details
    Browse the repository at this point in the history

  38. Update MetadataTests.testRulesOptions() to check entire rule file, … 

    …remove some special cases (nicklockwood#1799)
    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    e7bb487 View commit details
    Browse the repository at this point in the history

  39. Add --outputtokens option to print output tokens instead of source co… 

    …de (nicklockwood#1811)
    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    c780352 View commit details
    Browse the repository at this point in the history

  40. Fix issue where organizeDeclarations would add extra blank lines if t… 

    …ype had blank lines with spaces (nicklockwood#1810)
    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    a4cf33b View commit details
    Browse the repository at this point in the history

  41. Fix issue where unusedArguments didn't handle conditional assignment … 

    …shadowing (nicklockwood#1815)
    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    6310701 View commit details
    Browse the repository at this point in the history

  42. Add tests related to code organization and rule helper usage (nickloc… 

    …kwood#1808)
    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    ab4d327 View commit details
    Browse the repository at this point in the history

  43. Add preserve option to spaceAroundRangeOperators and spaceAroundOpera… 

    …torDeclarations (nicklockwood#1817)
    @calda @nicklockwood
    calda authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    fc6857d View commit details
    Browse the repository at this point in the history

  44. Add option to sort SwiftUI properties by the first property appearance ( 

    nicklockwood#1821)
    @miguel-jimenez-0529 @nicklockwood
    miguel-jimenez-0529 authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    bc39514 View commit details
    Browse the repository at this point in the history

  45. Remove redundant Void from protocol definitions (nicklockwood#1824)

    @miguel-jimenez-0529 @nicklockwood
    miguel-jimenez-0529 authored and nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    16af7f5 View commit details
    Browse the repository at this point in the history

  46. Fix wrapped array type extension mistaken for collection

    @nicklockwood
    nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    7689140 View commit details
    Browse the repository at this point in the history

  47. Move examples into rules files

    @nicklockwood
    nicklockwood committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    d94a4a7 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Fix missing lint output for organizeDeclarations rule (nicklockwood#1826 

    )
    @calda
    calda authored Aug 25, 2024
    Configuration menu
    Copy the full SHA
    5df3377 View commit details
    Browse the repository at this point in the history

  2. Fix typos discovered by codespell (nicklockwood#1835)

    @cclauss
    cclauss authored Aug 25, 2024
    Configuration menu
    Copy the full SHA
    df3106b View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Update minimum supported Swift version to Swift 5.7

    @calda
    calda committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    d2be392 View commit details
    Browse the repository at this point in the history

  2. Reformat code with --swiftversion 5.7

    @calda
    calda committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    0202f5e View commit details
    Browse the repository at this point in the history

  3. We only need one Package.swift now

    @calda
    calda committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    dbd22c8 View commit details
    Browse the repository at this point in the history