Fix conditional body wrapping inside single line string interpolation #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes "Cannot find ')' to match opening '(' in string interpolation" when line breaks are added in the middle of a single line string interpolation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1885 +/- ##
===========================================
- Coverage 95.14% 94.80% -0.34%
===========================================
Files 134 134
Lines 18985 18987 +2
===========================================
- Hits 18063 18001 -62
- Misses 922 986 +64 ☔ View full report in Codecov by Sentry. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We experienced a problem with the
wrapConditionalBodiesrule, where it would break compilation if a conditional body is inside a single line string as part of string interpolation.I've fixed the issue and added test coverage. The fix is using the same check that was added to fix an almost identical problem with ternary operator wrapping.