New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced floating line for new comments on proposals #292

Draft

fcamblor wants to merge 1 commit into nicmarti:dev from fcamblor:internal-comments-floating-line

Contributor

fcamblor commented Feb 12, 2022 •

edited

Loading

⚠️ testing still in progress - @aheritier found something which was maybe a bug in #285 comments :

I am not able to test the floating new messages feature for now because I already read all my notifications
Doing some random tests I saw the "Nouveaux messages" on the private window of QWC-2883 but it's strange because my counter of notifications is empty. It's the only talk I found like this ...

This PR brings a floating chronological line to identify new messages appeared since our last visit on a proposal :

sonarcloud bot commented Feb 12, 2022

SonarCloud Quality Gate failed.

2 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

aheritier assigned fcamblor

aheritier added the do-not-merge label

fcamblor force-pushed the internal-comments-floating-line branch from 865412b to 39195b5 Compare

November 20, 2022 22:34


          introduced floating line for new comments on proposals

012fd36

fcamblor force-pushed the internal-comments-floating-line branch from 39195b5 to 012fd36 Compare

November 20, 2022 23:20

sonarcloud bot commented Nov 20, 2022

SonarCloud Quality Gate failed.

2 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

aheritier marked this pull request as draft

January 21, 2023 12:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels