Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request for benjimons-develop branch. #3078

Open
wants to merge 2 commits into
base: benjimons-develop
Choose a base branch
from

Conversation

benjimons
Copy link

Thanks for your feedback and kind support - here is my changes against #3071

Disable by default maybe we can leave to the last bit.

I am not sure what to do about Windows - this is supposed to be a plain file reader so I dont know what else to do - i dont really want to get into reading event log files.

On the WebUI side of things I am a bit lost.

Description

Changes

  1. More memory efficiency
  2. Added warning for file not found
  3. Condensed headers.
  4. removed the 1GB colouring conditions
  • The plugin code should be optimize to be usable with huge log file without any impact on the Glances performance.
  • The plugin code should be compliant with Windows OS.
  • Configuration of the file size threshold should be done through the configuration file (not statically define to 1GB)
  • In the TUI, space is precious... PLease optimize the first 4 lines (TITLE, File name, File size, Last line header) to two or one line
  • In the WebUI refactor plugin-trailer.vue to work and be responsive
  • The plugin should be disable by default in the glances.conf file (for the moment, on the dev branch, il let it enable by default)

Resume

  • Bug fix: no
  • New feature: yes
  • Fixed tickets:

1. More memory efficiency
2. Added warning for file not faout
3. Condensed headers.
@benjimons benjimons changed the title Update __init__.py Pull request for benjimons-develop branch. Jan 5, 2025
@nicolargo
Copy link
Owner

Hi @benjimons

for Windows OS i think (hope) that the only think to do is take into account the carrier return. It is '\n' on Linux but '\r\n' on Windows.

@benjimons
Copy link
Author

@nicolargo maybe that should do it for the windows compatibility?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants