This repository has been archived by the owner on Aug 18, 2021. It is now read-only.
Bring branch up to date with master #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's best practise for inline js, minimizes render blocking.
Insert inline js at body end instead of header end
change posts primary title field from :name to :title
In windows newlines are \r\n, the extra \r causes it to fail to parse out the frontmatter.
Fixed windows markdown frontmatter newline bug
Fix canonical url
Use `title` as atom entry title, instead of `clojure.core/name`
Fix passed relativize-url argument in canonical-url task
…pace Use tools namespace to reload changed clojure ns instead of pod pools
Allows more control of entry metadata in the case of `markdown`, and any control at all in the case of `collection`
Each built-in task that modifies file metadata conjes a keyword onto the `:perun/trace` vector. This will aid in debugging, and possibly have applications in tasks.
The most immediate benefit of this change is that `markdown` no longer needs to manually track files removed from the fileset between invocations. As a result, `markdown` is shorter and simpler, and the same will be true of any future input parsing tasks.
Before this change, any task that called `add-filedata` would erase any perun metadata keys that were added by previous tasks, unless the previous keys were explicitly merged. This was necessary in order to prevent stale metadata from previous watch cycles from being carried over to the current state. However, since changing to file-level boot metadata, stale metadata is no longer a problem, and `add-filedata` can safely preserve previously-set keys automatically.
Testing improvements
Content pipeline
Trying to be consistent about these things. I also made the args a map, like `render-pre-wrap` and `content-pre-wrap`
I just discovered that when multiple tasks are in the same `testing` form, only the last one gets composed into the main task. This resulted in some checks being skipped.
Compose tests inside `testing` forms
Fileset Invictus
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a bit of time, so I figured I'd help out a little. The most relevant change was the implementation of the
asciidoctorplugin - I updated it to use the newcontent-pre-wrapabstraction. If you have any questions, or if you see other changes need to be made, let me know.