Ensure password slashing before validation #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the password-checking mechanism to include `wp_slash` for the input password to improve security. Additionally, added a mock implementation of `wp_slash` in `phpstan_bootstrap.php` for testing purposes.
Use `wp_slash` for password sanitization during user creation. Implement new tests to ensure registration and authentication work with passwords containing special characters. This ensures better security and functionality in handling complex passwords.
Use `wp_slash` for password sanitization during user creation. Implement new tests to ensure registration and authentication work with passwords containing special characters. This ensures better security and functionality in handling complex passwords.
Use `wp_slash` for password sanitization during user creation. Implement new tests to ensure registration and authentication work with passwords containing special characters. This ensures better security and functionality in handling complex passwords.
|
Thank you for contributing, @RenTheProgrammer. I will check this PR later this week. |
nicumicle
reviewed
Nov 11, 2024
| * @param string $value | ||
| * @return string | ||
| */ | ||
| public function sanitizePassword(string $value): string; |
There was a problem hiding this comment.
Please remove the return type, as the plugin can also be used in older PHP versions.
There was a problem hiding this comment.
Removed the return types! Sorry about that!
Update WordPressData.php
Update WordPressDataInterface.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the password-checking mechanism to include
wp_slashfor the input password to improve security. Additionally, added a mock implementation ofwp_slashinphpstan_bootstrap.phpfor testing purposes.Issue Link
#116
Types of changes
Description
Added the function wp_slash to further protect passwords coming from json
https://developer.wordpress.org/reference/functions/wp_slash/
How has this been tested?
added nullable parameter to the TestBase->registerRandomUser to pass a password. If the parameter is not null it overrides the $password field. This prevents code duplication.
Added Two new Test Cases.
Authentication/Success
RegisterUsers
Screenshots (optional)
Checklist:
composer check-pluginlocally