PR feedback

nielsbauman · Jun 4, 2024 · f84dbb5 · f84dbb5
1 parent b5c25d4
commit f84dbb5
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/...ms/src/internalClusterTest/java/org/elasticsearch/datastreams/DataStreamsSnapshotsIT.java b/...ms/src/internalClusterTest/java/org/elasticsearch/datastreams/DataStreamsSnapshotsIT.java
@@ -128,6 +128,7 @@ public void setup() throws Exception {
         response = client.execute(CreateDataStreamAction.INSTANCE, request).get();
         assertTrue(response.isAcknowledged());
 
+	// Initialize the failure store.
         RolloverRequest rolloverRequest = new RolloverRequest("with-fs", null);
         rolloverRequest.setIndicesOptions(
             IndicesOptions.builder(rolloverRequest.indicesOptions())

diff --git a/...rc/main/java/org/elasticsearch/action/admin/indices/rollover/TransportRolloverAction.java b/...rc/main/java/org/elasticsearch/action/admin/indices/rollover/TransportRolloverAction.java
@@ -236,7 +236,6 @@ protected void masterOperation(
         }
 
         // When we're initializing a failure store, we skip the stats request because there is no source index to retrieve stats for.
-        // Also, initializing a failure store is only supported without conditions, so we don't need the stats anyway.
         if (targetFailureStore && ((DataStream) rolloverTargetAbstraction).getFailureIndices().getIndices().isEmpty()) {
             initializeFailureStore(rolloverRequest, listener, trialSourceIndexName, trialRolloverIndexName);
             return;

diff --git a/...ava/org/elasticsearch/action/bulk/TransportBulkActionIndicesThatCannotBeCreatedTests.java b/...ava/org/elasticsearch/action/bulk/TransportBulkActionIndicesThatCannotBeCreatedTests.java
@@ -146,8 +146,8 @@ void executeBulk(
             }
 
             @Override
-            void createIndex(CreateIndexRequest requireDataStream, ActionListener<CreateIndexResponse> listener) {
-                String index = requireDataStream.index();
+            void createIndex(CreateIndexRequest createIndexRequest, ActionListener<CreateIndexResponse> listener) {
+                String index = createIndexRequest.index();
                 try {
                     simulateAutoCreate.accept(index);
                     // If we try to create an index just immediately assume it worked

diff --git a/server/src/test/java/org/elasticsearch/action/bulk/TransportBulkActionIngestTests.java b/server/src/test/java/org/elasticsearch/action/bulk/TransportBulkActionIngestTests.java
@@ -174,7 +174,7 @@ void executeBulk(
         }
 
         @Override
-        void createIndex(CreateIndexRequest requireDataStream, ActionListener<CreateIndexResponse> listener) {
+        void createIndex(CreateIndexRequest createIndexRequest, ActionListener<CreateIndexResponse> listener) {
             indexCreated = true;
             listener.onResponse(null);
         }

diff --git a/server/src/test/java/org/elasticsearch/action/bulk/TransportBulkActionTests.java b/server/src/test/java/org/elasticsearch/action/bulk/TransportBulkActionTests.java
@@ -105,7 +105,7 @@ class TestTransportBulkAction extends TransportBulkAction {
         }
 
         @Override
-        void createIndex(CreateIndexRequest requireDataStream, ActionListener<CreateIndexResponse> listener) {
+        void createIndex(CreateIndexRequest createIndexRequest, ActionListener<CreateIndexResponse> listener) {
             indexCreated = true;
             if (beforeIndexCreation != null) {
                 beforeIndexCreation.run();

diff --git a/server/src/test/java/org/elasticsearch/action/bulk/TransportSimulateBulkActionTests.java b/server/src/test/java/org/elasticsearch/action/bulk/TransportSimulateBulkActionTests.java
@@ -83,7 +83,7 @@ class TestTransportSimulateBulkAction extends TransportSimulateBulkAction {
         }
 
         @Override
-        void createIndex(CreateIndexRequest requireDataStream, ActionListener<CreateIndexResponse> listener) {
+        void createIndex(CreateIndexRequest createIndexRequest, ActionListener<CreateIndexResponse> listener) {
             indexCreated = true;
             if (beforeIndexCreation != null) {
                 beforeIndexCreation.run();