101: Allow the noPaperTrail option to be set via continuation-local-s… #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlw0
commented
Apr 3, 2020
| @@ -6,7 +6,5 @@ module.exports = (sequelize, DataTypes) => { | |||
| // associations can be defined here | |||
| }; | |||
|
|
|||
| User.Revision = User.hasPaperTrail(); | |||
There was a problem hiding this comment.
I had to remove this line for a couple reasons. First, this line was causing the hooks to be registered twice for this model since this method is also called in the tests. Second, if we call "hasPaperTrail" here, the hooks will not be compatible with the CLS.
|
@nielsgl it has been a while since the last release. Is this project still active? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
101: Allow the noPaperTrail option to be set via continuation-local-storage
#101