Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on permalink failure. #237

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

alan-wu
Copy link
Contributor

@alan-wu alan-wu commented Dec 10, 2024

The API server fails to retrieve permalink or return permalink information occasionally. This pull request implement a workaround by allowing the API calls 3 times.

I have tested this locally by manually setting up the affected API calls to only succeed once every 5 calls and this workaround is handling it well.

I have deployed an instance here but users should not see any difference normally.
https://alan-wu-sparc-app.herokuapp.com/

@alan-wu alan-wu requested review from ddjnw1yu and akhuoa December 10, 2024 00:10
Copy link

cypress bot commented Dec 10, 2024

SPARC Vue3 Portal Testing    Run #347

Run Properties:  status check passed Passed #347  •  git commit 109025e02e: Retry on permalink failure.
Project SPARC Vue3 Portal Testing
Branch Review permalink-fix
Run status status check passed Passed #347
Run duration 15m 16s
Commit git commit 109025e02e: Retry on permalink failure.
Committer alan-wu
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 25
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 174
View all changes introduced in this branch ↗︎

Copy link
Collaborator

@ddjnw1yu ddjnw1yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@alan-wu alan-wu merged commit 277dbab into nih-sparc:main Dec 10, 2024
6 checks passed
@alan-wu alan-wu deleted the permalink-fix branch December 10, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants