-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Biolucida viewer from image viewer #326
base: master
Are you sure you want to change the base?
Conversation
Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.16.3 to 4.16.8. - [Release notes](https://github.com/browserslist/browserslist/releases) - [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md) - [Commits](browserslist/browserslist@4.16.3...4.16.8) --- updated-dependencies: - dependency-name: browserslist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [striptags](https://github.com/ericnorris/striptags) from 3.1.1 to 3.2.0. - [Release notes](https://github.com/ericnorris/striptags/releases) - [Commits](ericnorris/striptags@v3.1.1...v3.2.0) --- updated-dependencies: - dependency-name: striptags dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…com:nih-sparc/sparc-app into biolucida-viewer
…nih-sparc/sparc-app into biolucida-viewer
…:nih-sparc/sparc-app into biolucida-viewer
…instead of fullscreen option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gallery doesn't seem to show on dateset 43?
When I go to the given link for testing, I get the following error:
Is there something I'm missing to be able to test this?
I think @Tehsurfer I would suggest that things are not setup correctly. The given link is a relative link for the segmentation viewer. The link you have posted is for localhost, for that to work you would have to use the branches in both sparc-app and sparc-api and fully build the application. I don't know where you posted that image from showing no image gallery for dataset 43. That makes it hard to understand why it might not be working. On all the websites that have been setup with this functionality the image gallery is present for this dataset. |
Description
Change the view in full screen button to open the image in the Biolucida viewer application.
Type of change
How Has This Been Tested?
Using the relative link: datasets/biolucidaviewer/2720?view=MjcyMC1jb2wtMTA4&dataset_version=5&dataset_id=43&item_id=N%3Apackage%3A7d2541f3-32ca-402b-9685-aaac8a4c9732
Clicking the 'View in 3D' button:
Will open the Biolucida viewer application if you have it or direct you to a page for next steps if you don't.
Checklist: