Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paremeter queries in maps page to make it constructable. #770

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

alan-wu
Copy link
Contributor

@alan-wu alan-wu commented Nov 16, 2023

Description

Improve query parameters on the maps page to make the link constructable manually. Please check here for the details: https://docs.google.com/document/d/1N4Z2h2XJad4ReskSb8eTtWyNLJ9NZoJK4MNtIzAt_sA/edit#heading=h.p6kg75rdm3u0

Type of change

Delete those that don't apply.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I have tested this manually and it should not break any backward compatibility.

I have also deployed the sample links:
New query parameters with AC maps:
https://alan-wu-sparc-app.herokuapp.com/maps?type=ac&dataset_version=5&dataset_id=102&taxon=NCBITaxon%3A9823&anatomy=UBERON%3A0000948&for_species=pig

The old query parameters with type=flatmap, taxo and uberonid still works:
https://alan-wu-sparc-app.herokuapp.com/maps?type=flatmap&dataset_version=5&dataset_id=102&taxo=NCBITaxon%3A9823&uberonid=UBERON%3A0000948&for_species=pig

Features on FC map can be highlighted as well:
https://alan-wu-sparc-app.herokuapp.com/maps?type=fc&anatomy=heart

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have utilized components from the Design System Library where applicable
  • I have added or updated unit tests that prove my fix is effective or that my feature works
  • I updated any relevant QC tests to match my changes found here: https://docs.google.com/document/d/1tlV89PMOv8XlmC7LVqifi7NfQ5-AYN8DuEQpmO7O_2Q

Copy link

cypress bot commented Nov 16, 2023

Passing run #4 ↗︎

0 12 0 0 Flakiness 0

Details:

Update a comment.
Project: SPARC Portal E2E testing Commit: 1df383c6d4
Status: Passed Duration: 00:44 💡
Started: Nov 21, 2023 8:21 PM Ended: Nov 21, 2023 8:21 PM

Review all test suite changes for PR #770 ↗︎

@alan-wu alan-wu requested a review from Tehsurfer November 19, 2023 23:56
Copy link
Contributor

@Tehsurfer Tehsurfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good :)

The new function makes more sense

@alan-wu alan-wu merged commit 8b70e34 into nih-sparc:master Nov 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants