Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated gtm push events #771

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Updated gtm push events #771

merged 1 commit into from
Nov 21, 2023

Conversation

egauzens
Copy link
Contributor

Description

Updated events to reflect what Tess wants. Added a middleware to clear the datalayer between page views

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Locally via tag assistant

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have utilized components from the Design System Library where applicable
  • I have added or updated unit tests that prove my fix is effective or that my feature works
  • I updated any relevant QC tests to match my changes found here: https://docs.google.com/document/d/1tlV89PMOv8XlmC7LVqifi7NfQ5-AYN8DuEQpmO7O_2Q

@cypress Cypress
Copy link

cypress bot commented Nov 21, 2023

Passing run #3 ↗︎

0 12 0 0 Flakiness 0

Details:

Updated gtm push events
Project: SPARC Portal E2E testing Commit: d2cb585313
Status: Passed Duration: 00:54 💡
Started: Nov 21, 2023 4:30 PM Ended: Nov 21, 2023 4:31 PM

Review all test suite changes for PR #771 ↗︎

SamanthaKraft
SamanthaKraft approved these changes Nov 21, 2023
View reviewed changes
Copy link

@SamanthaKraft SamanthaKraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@egauzens egauzens merged commit 74480dc into nih-sparc:master Nov 21, 2023
2 checks passed
@egauzens egauzens deleted the convert-gtm-events-to-messages branch November 21, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamanthaKraft SamanthaKraft SamanthaKraft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egauzens @SamanthaKraft